Open
Conversation
Author
…ImageView - work in progress
Author
Member
There was a problem hiding this comment.
Comments who created and when given class are superfluous (we have git history). We also promote shared code ownership, so after a while it really does not matter who created what and when. I tend to avoid comments that bring no value :D
Member
|
Very nice change! Since it's learning exercise I tried to be thorough reviewer and pointed out some minute details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced Chuck Norris with profile pictures of Polidea employees. New coverflow shows all the avatars.