-
Notifications
You must be signed in to change notification settings - Fork 128
Refactor a bunch of old APIs, add some new APIs, and add fallback addon #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dfsek
wants to merge
46
commits into
master
Choose a base branch
from
blockstate-fallback-and-refactors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think that we will have higher-order types with more than 2 parameters, so I only made K and K2
Member
Author
|
I have no idea why the CI is failing, I looked briefly and it was something about javadocs, I will investigate this later |
Member
Author
|
As I go i am also refactoring any getters I encounter to record-style getters. ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a whole bunch of stuff, at this point it's basically "dfsek's original 7.0 ideas lite"
Let me know if there are any specific things you want me to revert.
So far we have:
OptionalwithMaybeto play nice with new APIs.Planned:
manifest-addon-loader->addon-loader-manifestapi-addon-loader->addon-loader-apipalette-block-shortcut->shortcut-palette-blockThere will probably be more things that I may or may not remember to add to this comment :)