This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Add option to set a specific value sent to the server for each option AND fire 'change'#195
Open
mercmobily wants to merge 6 commits intoPolymerElements:masterfrom
Open
Add option to set a specific value sent to the server for each option AND fire 'change'#195mercmobily wants to merge 6 commits intoPolymerElements:masterfrom
mercmobily wants to merge 6 commits intoPolymerElements:masterfrom
Conversation
At the moment, if you have a dropdown menu like this:
<paper-dropdown-menu name="country" id="country" label="Your country">
<paper-listbox attr-for-selected="choice" selected="[[countryDefault]]" class="dropdown-content">
<paper-item choice="it">Italy</paper-item>
<paper-item choice="fr">France</paper-item>
<paper-item choice="">Other</paper-item>
</paper-listbox>
</paper-dropdown-menu>
After submitting, the server will receive "Italy", "France" or "". There is no way, at the moment, for it to behave like a native select box:
<select>
<option value="it">Italy</option>
<option value="fr">France</option>
<option value="">Other</option>
</select>
The only option to send the right data to the server is by setting the "label" attribute for the various <paper-items> elements. However, this has the side effect that after making the selection, the user will see "it", "fr" etc.
This patch addresses that: if `value` is set for the selected item, THAT is the value considered and assigned to the paper-dropdown-menu.
I wouldn't have tortured you with a PR if I had found a way to do this in other ways... sorry!
Author
|
Just so that you know how desperate I am for this patch, this is what I am in my main app :D |
Author
|
I just broadened the scope of this PR a little. I noticed that 4 tests fail with this latest change. Maybe it's me doing something stupid; I can't figure out why they would though. |
…ction. Important so that labels and values can be ''
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, if you have a dropdown menu like this:
After submitting, the server will receive "Italy", "France" or "". There is no way, at the moment, for it to behave like a native select box:
The only option to send the right data to the server is by setting the "label" attribute for the various elements. However, this has the side effect that after making the selection, the user will see "it", "fr" etc.
This patch addresses that: if
valueis set for the selected item, THAT is the value considered and assigned to the paper-dropdown-menu.I wouldn't have tortured you with a PR if I had found a way to do this in other ways... sorry!