This repository was archived by the owner on Dec 19, 2024. It is now read-only.
restore input to default if no element is selected#211
Open
davidcv5 wants to merge 1 commit intoPolymerElements:masterfrom
davidcv5:master
Open
restore input to default if no element is selected#211davidcv5 wants to merge 1 commit intoPolymerElements:masterfrom davidcv5:master
davidcv5 wants to merge 1 commit intoPolymerElements:masterfrom
davidcv5:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
paper-dropdown-menu-lightshows label out of place when an item is selected and then all items are removed. i.e. Binding items to a firebase-query or any other dynamic source.Expected outcome
paper-dropdown-menu-lightshould return to its default state if all content is removed.Actual outcome
After items get deleted, the innerHTML of
<div id="input"...is empty, instead of , which makes the div smaller and causes the label to show out of place.Steps to reproduce
paper-dropdown-menu-lighton the page.paper-menuinside withclass="dropdown-content".<template is="dom-repeat" ..inside withitemspointing to anarrayarrayusing the corresponding array mutation methods.Test case: https://jsbin.com/qufitil/edit?html,output