fix: flatten core model params #168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
requested changes
Jan 20, 2025
Member
Twixes
left a comment
Twixes
left a comment
There was a problem hiding this comment.
This looks good, but we'll have to duplicate the effort in other SDKs (TypeScript), so proposing inlining into the plugin server too!
| return model_params | ||
|
|
||
|
|
||
| def extract_core_model_params(kwargs: Dict[str, Any], provider: str) -> Dict[str, Any]: |
Member
There was a problem hiding this comment.
Let's do this in the plugin server, so that we only have to update one place to cover all SDKs!
| Extracts core model parameters from the kwargs dictionary. | ||
| """ | ||
| output = {} | ||
| if provider == "anthropic": |
Member
There was a problem hiding this comment.
To track AI cost processing's case-insensitive behavior:
Suggested change
| if provider == "anthropic": | |
| if provider: | |
| provider = provider.lower() | |
| if provider == "anthropic": |
Comment on lines
+47
to
+48
| if "max_completion_tokens" in kwargs: | ||
| output["$ai_max_tokens"] = kwargs.get("max_completion_tokens") |
Member
There was a problem hiding this comment.
Might also be clearest to standardize on max_completion_tokens (though hard to say if other providers releasing reasoning models will follow this naming)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract core values from model params.