Skip to content

Conversation

@tinoue
Copy link
Collaborator

@tinoue tinoue commented Oct 27, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tinoue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and accuracy of shooting rule descriptions within the system. It involves a comprehensive review and standardization of language used in the English rule descriptions, particularly for freestyle, precision pistol, APS, ISSF, and WFDA categories. The changes aim to provide users with more precise and consistent information regarding competition rules, along with corresponding updates to database commit identifiers.

Highlights

  • Rule Description Clarity: Standardized and clarified various phrases in the English descriptions of shooting rules, such as changing "Pointing allowed" to "Aiming allowed" and refining gun type specifications for improved readability and accuracy.
  • WFDA Rule Updates: Specific updates were made to the descriptions and associated URLs for WFDA (World Fast Draw Association) rules, including more precise details on starting hand positions and distance-specific documentation links.
  • Database Commit ID Updates: The commit IDs for the Realm and SQLite catalog databases have been updated, reflecting the data changes introduced in the ShootingRuleCatalog.csv file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the descriptions of shooting rules in the ShootingRuleCatalog.csv file, replacing instances of "Pointing allowed before start signal" with "Aiming allowed before the start signal", and making minor adjustments to the wording of some descriptions. There are also changes to the starting position descriptions for some fast draw rules.

125,"wfda","40cm Pre-Cocked Fast Draw Standing BB","40cm (16in), single shot in 1 sec, 7 shots. Scored by time to hit; best 5/7 total. Pre-cocked handgun only. Standing with holster. Start hand-at-side, near but not touching","/docs/competition-rules/fast-draw-standing-bb","40cm プリコック ファストドロー スタンディングBB","40cm, 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。プリコック状態のハンドガンのみ使用可。要ホルスター。立射。スタートはハンズアットサイドポジション(手を銃およびホルスターに触れず、近くに置いた状態)","",40,0,"speed_shooting",1,1,0,1,1,7,0
130,"wfda","5ft Fast Draw Standing BB","5ft, single shot in 1 sec, 7 shots. Scored by time to hit; best 5/7 total. Revolvers only, fired in single action. Standing with holster. Start hand-at-side, near but not touching.","/docs/competition-rules/fast-draw-standing-bb","1.5m ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。リボルバーのみ使用可(シングルアクション操作)。要ホルスター。立射。スタートはハンズアットサイドポジション(手を銃およびホルスターに触れず、近くに置いた状態)","",500,2,"speed_shooting",1,1,0,1,1,7,0
135,"wfda","5ft Pre-Cocked Fast Draw Standing BB","5ft, single shot in 1 sec, 7 shots. Scored by time to hit; best 5/7 total. Pre-cocked handgun only. Standing with holster. Start hand-at-side, near but not touching","/docs/competition-rules/fast-draw-standing-bb","1.5m プリコック ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。プリコック状態のハンドガンのみ使用可。要ホルスター。立射。スタートはハンズアットサイドポジション(両手を銃およびホルスターに触れず、近くに置いた状態)","",500,2,"speed_shooting",1,1,0,1,1,7,0
1,"","5m Slow Fire Freestyle","5m (5.47yds), 10 shots in 4 min. Any type of guns, sights, and firing positions are allowed. Aiming allowed before the start signal.","/docs/competition-rules/freestyle","5m 精密射撃 フリースタイル","5m, 10発/4分。銃の種類・サイト・射撃姿勢、いずれも制限なし。開始合図の前に照準可。","",500,0,"",0,0,0,10,240,1,2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description has been updated to use "Aiming allowed before the start signal." This is a good clarification for the rule description.

@tinoue tinoue merged commit dfb1ae0 into main Oct 27, 2025
1 check passed
@tinoue tinoue deleted the update-shooting-rule branch October 27, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants