Update shooting rule descriptions #24
Conversation
…scriptions and unify format for clarity
Summary of ChangesHello @tinoue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the clarity and accuracy of shooting rule descriptions within the system. It involves a comprehensive review and standardization of language used in the English rule descriptions, particularly for freestyle, precision pistol, APS, ISSF, and WFDA categories. The changes aim to provide users with more precise and consistent information regarding competition rules, along with corresponding updates to database commit identifiers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the descriptions of shooting rules in the ShootingRuleCatalog.csv file, replacing instances of "Pointing allowed before start signal" with "Aiming allowed before the start signal", and making minor adjustments to the wording of some descriptions. There are also changes to the starting position descriptions for some fast draw rules.
| 125,"wfda","40cm Pre-Cocked Fast Draw Standing BB","40cm (16in), single shot in 1 sec, 7 shots. Scored by time to hit; best 5/7 total. Pre-cocked handgun only. Standing with holster. Start hand-at-side, near but not touching","/docs/competition-rules/fast-draw-standing-bb","40cm プリコック ファストドロー スタンディングBB","40cm, 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。プリコック状態のハンドガンのみ使用可。要ホルスター。立射。スタートはハンズアットサイドポジション(手を銃およびホルスターに触れず、近くに置いた状態)","",40,0,"speed_shooting",1,1,0,1,1,7,0 | ||
| 130,"wfda","5ft Fast Draw Standing BB","5ft, single shot in 1 sec, 7 shots. Scored by time to hit; best 5/7 total. Revolvers only, fired in single action. Standing with holster. Start hand-at-side, near but not touching.","/docs/competition-rules/fast-draw-standing-bb","1.5m ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。リボルバーのみ使用可(シングルアクション操作)。要ホルスター。立射。スタートはハンズアットサイドポジション(手を銃およびホルスターに触れず、近くに置いた状態)","",500,2,"speed_shooting",1,1,0,1,1,7,0 | ||
| 135,"wfda","5ft Pre-Cocked Fast Draw Standing BB","5ft, single shot in 1 sec, 7 shots. Scored by time to hit; best 5/7 total. Pre-cocked handgun only. Standing with holster. Start hand-at-side, near but not touching","/docs/competition-rules/fast-draw-standing-bb","1.5m プリコック ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。プリコック状態のハンドガンのみ使用可。要ホルスター。立射。スタートはハンズアットサイドポジション(両手を銃およびホルスターに触れず、近くに置いた状態)","",500,2,"speed_shooting",1,1,0,1,1,7,0 | ||
| 1,"","5m Slow Fire Freestyle","5m (5.47yds), 10 shots in 4 min. Any type of guns, sights, and firing positions are allowed. Aiming allowed before the start signal.","/docs/competition-rules/freestyle","5m 精密射撃 フリースタイル","5m, 10発/4分。銃の種類・サイト・射撃姿勢、いずれも制限なし。開始合図の前に照準可。","",500,0,"",0,0,0,10,240,1,2 |
There was a problem hiding this comment.
The description has been updated to use "Aiming allowed before the start signal." This is a good clarification for the rule description.
No description provided.