feat: update catalog database #25
Conversation
…t draw challenges, enhancing clarity and consistency in descriptions
… changes in realm and sqlite databases
…lity status and add new Kar98k entry
…ite to reflect recent changes
…ite to reflect recent changes
…ite to reflect latest changes
Summary of ChangesHello @tinoue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating and refining the catalog database. It addresses data accuracy by correcting a typo and enhancing the gun catalog with a new entry. Additionally, it significantly improves the clarity and scope of shooting rule definitions, ensuring they are more precise and inclusive. These data modifications are reflected in the updated database commit IDs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the catalog data for guns and shooting rules. The changes include a typo fix from 'UPS' to 'USP', a power level adjustment for one gun model, and the addition of a new gun. For shooting rules, several 'Fast Draw' rules have been updated, changing 'Pre-Cocked' to 'Cocked' and clarifying the allowed firearm conditions. My review includes suggestions to improve data completeness for the new gun entry and to address a potential inconsistency in the shooting rule types.
| 13111,"crown","SUPER RIFLE DRAGUNOV SVD","","","スーパーライフルドラグノフSVD","","",2,1,0,, | ||
| 13112,"crown","TYPE96 SENIOR","","","タイプ96 シニア","","",2,1,2,, | ||
| 13112,"crown","TYPE96 SENIOR","","","タイプ96 シニア","","",2,1,0,, | ||
| 13113,"crown","Kar98k","","","","","",2,1,0,, |
There was a problem hiding this comment.
This new entry for the Kar98k is missing Japanese names (shortNameJa, fullNameJa). While these fields are optional according to docs/GunCatalog.md, most other entries include them. For consistency and to improve localization, please consider adding the Japanese names. For example, Kar98k could be used for shortNameJa.
| 125,"wfda_jp","40cm Cocked Fast Draw Standing BB","40cm (16in), single shot in 1 sec x 7 strings. Scored by time to hit; best 5/7 total. Handguns only: semi-autos with safety off or revolvers hammer cocked. Standing with holster. Start with hands at sides, not touching the gun.","/docs/competition-rules/40cm-fast-draw-standing-bb","40cm コック済 ファストドロー スタンディングBB","40cm, 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。オートマティックはセーフティ解除、リボルバーはハンマーコック可。要ホルスター。立射。スタートはハンズアットサイドポジション(手を銃に触れず、近くに置いた状態)","",40,0,"speed_shooting",1,1,0,1,1,7,0 | ||
| 130,"wfda","5ft Fast Draw Standing BB","5 ft (1.5m), single shot in 1 sec x 7 strings. Scored by time to hit; best 5/7 total. Revolvers only, fired in single action. Standing with holster. Hand on the gun at start, finger outside the trigger guard.","/docs/competition-rules/5ft-fast-draw-standing-bb","1.5m ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。リボルバーのみ使用可(シングルアクション操作)。要ホルスター。立射。銃に片手を置き、トリガーに指をかけない状態でスタート","",500,2,"speed_shooting",1,1,0,1,1,7,0 | ||
| 135,"wfda","5ft Pre-Cocked Fast Draw Standing BB","5 ft (1.5m), single shot in 1 sec x 7 strings. Scored by time to hit; best 5/7 total. Pre-cocked handgun only. Standing with holster. Hand on the gun at start, finger outside the trigger guard.","/docs/competition-rules/5ft-fast-draw-standing-bb","1.5m プリコック ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。プリコック状態のハンドガンのみ使用可。要ホルスター。立射。銃に片手を置き、トリガーに指をかけない状態でスタート","",500,2,"speed_shooting",1,1,0,1,1,7,0 | ||
| 135,"wfda","5ft Cocked Fast Draw Standing BB","5 ft (1.5m), single shot in 1 sec x 7 strings. Scored by time to hit; best 5/7 total. Handguns only: semi-autos with safety off or revolvers hammer cocked. Standing with holster. Hand on the gun at start, finger outside the trigger guard.","/docs/competition-rules/5ft-fast-draw-standing-bb","1.5m コック済 ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。オートマティックはセーフティ解除、リボルバーはハンマーコック可。要ホルスター。立射。銃に片手を置き、トリガーに指をかけない状態でスタート","",500,2,"speed_shooting",1,1,0,1,1,7,0 |
There was a problem hiding this comment.
There appears to be an inconsistency in the type field. The rules with _id 120 and 125 were updated to type: 'wfda_jp', but this rule (_id: 135) was not, even though it received similar updates to rule 125. For consistency, should this rule's type also be wfda_jp? This might also apply to the related rule with _id 130.
135,"wfda_jp","5ft Cocked Fast Draw Standing BB","5 ft (1.5m), single shot in 1 sec x 7 strings. Scored by time to hit; best 5/7 total. Handguns only: semi-autos with safety off or revolvers hammer cocked. Standing with holster. Hand on the gun at start, finger outside the trigger guard.","/docs/competition-rules/5ft-fast-draw-standing-bb","1.5m コック済 ファストドロー スタンディングBB","5フィート(1.5m), 1発/1秒 x 7回。命中までの時間で採点、上位5発を合計。オートマティックはセーフティ解除、リボルバーはハンマーコック可。要ホルスター。立射。銃に片手を置き、トリガーに指をかけない状態でスタート","",500,2,"speed_shooting",1,1,0,1,1,7,0
No description provided.