Skip to content

proxy fix #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcholic merged 1 commit into from
Jan 1, 2026
Merged

proxy fix #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ export class SentienceBrowser {
}

// Support proxy from parameter or environment variable
this._proxy = proxy || process.env.SENTIENCE_PROXY;
// Only use env var if it's a valid non-empty string
const envProxy = process.env.SENTIENCE_PROXY;
this._proxy = proxy || (envProxy && envProxy.trim() ? envProxy : undefined);

// Auth injection support
this._userDataDir = userDataDir;
Expand Down Expand Up @@ -512,7 +514,7 @@ export class SentienceBrowser {
* @returns Playwright proxy object or undefined if invalid
*/
private parseProxy(proxyString?: string): { server: string; username?: string; password?: string } | undefined {
if (!proxyString) {
if (!proxyString || !proxyString.trim()) {
return undefined;
}

Expand Down