Open
Conversation
call needed to be renamed to spcall as there is already another call function
It was using a dict with worst case complexity for append and get equal to O(n) while list has O(1) for this operations, which are the only ones being used. Additionally this removes the need of carrying a counter.
- Double blank lane wrapping module level functions
- 4-space indentation
- no-space after "("
- single-space after ","
- single-space before and after "="
- single-space before and after "+"
- no-space before ")"
- no-space before ":"
- no-space between "print" and "("
Contributor
|
hi, can you help us by identifying the tutorial or instructions you were following which prompted these merge requests? Maybe provide a little more context? |
Author
|
I got this repository's URL from a git clone command on one of the getting started tutorials, and I was curious so inspected it. The changes are purely Pythonic. |
Contributor
|
alrighty, we'll review then. always good to get improvements from an expert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description of the commits have the information needed.