Skip to content

Conversation

@SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Mar 20, 2024

Questions Answers
Description? a9c26ce added .js- selectors in few places.
The one for order returns got messed up. It's supposed to be:
#order-return-form table thead input[type=checkbox], .js-order-return-form table thead input[type=checkbox]
#order-return-form table tbody input[type=checkbox], .js-order-return-form table tbody input[type=checkbox]
but instead it became:
#order-return-form, .js-order-return-form table thead input[type=checkbox]
#order-return-form, .js-order-return-form table tbody input[type=checkbox].
This pr simplifies the selectors and the function to check all products for return.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? 1. Have an order with several products in your customer account
2. Start a return process and see if you can check all products at once from the table header

@SharakPL SharakPL requested a review from a team March 20, 2024 20:15
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Jan 23, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for QA Status: Waiting for QA feedback

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.

3 participants