Skip to content

Conversation

@ShaiMagal
Copy link
Contributor

@ShaiMagal ShaiMagal commented Nov 7, 2024

Questions Answers
Description? Add missing classes for CSS/JS targeting. Partially related to issue #37333. If this PR will be accepted, I will do same for hummingbird.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #37333
Sponsor company https://www.openservis.cz/
How to test?

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 11, 2024

@kpodemski We didn't find any better solution for this usecase. So we decided to at least add classes like in the top cart summary here, so we can change it by JS.

Do you have any better names for the classes or it's ok?

@ShaiMagal ShaiMagal changed the base branch from develop to 2.1.x November 11, 2024 14:10
@ShaiMagal
Copy link
Contributor Author

@kpodemski adding classes at least is small thing and every theme should have classes for CSS targeting, so I think, this PR isn't problem .)

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Jan 23, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jan 23, 2026
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, sorry, this PR has been forgotten :(

I think you should rebase to at least v9.0 base branch.

CC @Hlavtox what do you think?

@kpodemski kpodemski removed the Waiting for QA Status: Waiting for QA feedback label Jan 23, 2026
@ps-jarvis ps-jarvis moved this from To be tested to Waiting for author in PR Dashboard Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for author

Development

Successfully merging this pull request may close these issues.

5 participants