-
Notifications
You must be signed in to change notification settings - Fork 30
prime tunnel #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
prime tunnel #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| except (BlockingIOError, IOError): | ||
| pass | ||
| finally: | ||
| fcntl.fcntl(fd, fcntl.F_SETFL, fl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stderr not drained during connection wait causing potential timeout
Medium Severity
During _wait_for_connection(), only stdout is read while waiting for the "start proxy success" message. The stderr pipe is never read until the process exits. If frpc outputs substantial data to stderr during startup (warnings, debug logs), the pipe buffer could fill up, causing frpc to block before writing the success message to stdout, resulting in a false timeout.
Note
Adds a new tunneling capability and integrates it into the CLI.
packages/prime-tunnelSDK withTunnel,TunnelClient,Config, models, and exceptionsbinary.py) with platform-aware download, extraction, and versioningcreate/get/list/delete)Tunnelorchestration: writes frpc config, launches subprocess, waits for connection, cleans upprime tunnelcommands (start,list,status,stop) and wires into main app; updates dependencies and workspace manifestWritten by Cursor Bugbot for commit 3ba86e0. This will update automatically on new commits. Configure here.