Feedback cli #321
Feedback cli #321
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| console.print("[green]Feedback submitted. Thanks![/green]") | ||
| else: | ||
| console.print("[red]Failed to send. Please try again or email support@primeintellect.ai[/red]") | ||
| raise typer.Exit(1) |
There was a problem hiding this comment.
Entire feedback utility module is unused dead code
Medium Severity
The entire utils/feedback.py module is dead code. The application imports and uses commands/feedback.py instead (via main.py). This file duplicates send_feedback() and prompt_for_feedback() with a different implementation (Slack webhook vs API), and defines run_feedback_command() which is never called. Additionally, the hardcoded placeholder webhook URL (https://hooks.slack.com/services/YOUR/WEBHOOK/URL) would fail silently if this code were ever used.
| if category is None: | ||
| category = prompted_category | ||
| if run_id is None: | ||
| run_id = prompted_run_id |
There was a problem hiding this comment.
User prompts ignored when CLI flags preset values
Medium Severity
When --bug, --feature, or --run options are provided without a message, the command enters interactive mode via prompt_for_feedback() which prompts for category and run ID. However, lines 166-169 only use the prompted values if the corresponding CLI option was not set. This means users are prompted to select a feedback type or enter a run ID, but their input is silently ignored because the flag-provided value takes precedence. The user has no indication their selection won't be used.
|
@cdreetz Can you rebase the PR on the newest main branch? |
Introduces
prime feedbackcommand to the prime cli. Focus is for hosted rl feedback but gives the option for "other" feedback as well.Corresponding platform PR: https://github.com/PrimeIntellect-ai/platform/pull/167
Note
Adds a user-facing way to submit feedback from the CLI and a utility for Slack delivery.
prime feedbackcommand (commands/feedback.py) with--bug,--feature,--runoptions or fully interactive prompts; sends feedback to API viaPOST /feedbackwithmessage,product,category,run_id,cli_version, and user/team contextmain.pyunder the Account section (prime feedback)utils/feedback.pyproviding Slack webhook submission (PRIME_FEEDBACK_WEBHOOK) with enriched user/team metadata and interactive prompting helperscommands/rl.pyWritten by Cursor Bugbot for commit 1e38091. This will update automatically on new commits. Configure here.