Conversation
logan-nc
reviewed
Nov 26, 2024
| WRITE(out_unit,'(1x,a2,14(1x,a16))')"l","r","z", | ||
| $ "real(A_r)","imag(A_r)","real(A_z)","imag(A_z)", | ||
| $ "real(A_phi)","imag(A_phi)", | ||
| $ "real(dAr/dz)","imag(dAr/dz)", |
Contributor
There was a problem hiding this comment.
Please keep a consistent naming convention. Ar → A_r
Contributor
|
I do not think this should be a diagnostic. It should just be directly in gpout. All the potentials are already computed on the cylindrical grid there, so this approach is doubling the work. The or even just put it into the Note also that the chebyshev vector potential is also available already, as are the b fields. Am I missing something here that made you put it as a diagnostic instead of usual output? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@logan-nc and @parkjk, I just wanted to have ASCII vector potential in cylinder, and its gradient to give this result to other codes and compare. Is it okay?
I added "arzphicyl_flag" that prints out these variables.
