Conversation
…ixed typos and updated compile instructions in DEFAULTS.inc
…al surface present
|
@StuartBenjamin you are one of the few who knows the guts of RMATCH... can you take a very brief look at these comments (in f27f665) and let me know if there should be any changes/if you know what some of the 'unknown's are? |
StuartBenjamin
left a comment
There was a problem hiding this comment.
Remembered a few of the extra terms!
… rmatch.ins, implemented Stuart's improvements.
…ch.in. Now, if not doing a scan and using rpec_flag, eigenvalue will be calculated based on the input rotation at a rational surface.
…rming LAR equilibria
…ies to be written to globalsol.bin for gpec
…eal/kin dcon eigenfunctions so the parallels are clear and readable
…ies to be read by rmatch
…into gpec as a diagnositc; fixed a breaking bug where match.f would dump too many psi points into galsol.bin, leading to the inner layer looking broken and being incorrect; Added xdraw files for RPEC solutions; improved a couple of rmatch numerical factors, including scaling the number of inner layer grid points by its width to keep the physical resolution consistent, as well as moving the resonant cell widths outside of this scaling to keep their widths consistent regardless of inner layer width.
…ated written vacuum file to equil.f to avoid repeating code with multiple confusing variables of the same name in different namelists
…dth and interpolation scaling; updated related functions to utilize these parameters
…ut; refactored equil.f to separate loading of namelists; modified global.f to enable vacuum memory; adjusted makefile dependencies
230689a to
e931e67
Compare
…atch.f to reduce write overhead; added new variables for sweet spots and Lundquist Number in gpec profile netcdfs
…t minimum; fixed real -> complex eigenvalue from RMATCH io
…increased number of steps to read for better tokamaker edge compatibility, narrowed penetrated field interpolation region, final version for resistive metrics paper
2b4b094 to
1823cd3
Compare
…merics, modernized some namelist options, setup final resistive spot size logic.
|
@logan-nc I had to disable @StuartBenjamin's logic for setting psihigh for RDCON in order for RPEC to continue working -- it remains a mystery to me as to why this was a problem. |
|
@logan-nc The problems wound up being that the way rdcon was regridding was cutting off at a different psilim than I expected, resulting in the poorly conditioned solution set that we know occurs at some psi cutoff values. I haven't run it yet, but I think I should be able to get it to work nicely with Stuart's regridding contributions. Hopefully I'm not dooming it by speaking too soon! |
|
@claude Please briefly summarize this PR. |
|
Claude finished @matt-pharr's task in 1m 9s —— View job Summary of PR #210: Resistive Singular CouplingThis PR enhances GPEC's resistive MHD analysis capabilities by implementing scientifically robust singular coupling between RDCON (resistive stability) and GPEC (perturbed equilibrium) codes. The work enables accurate 3D field penetration calculations at rational surfaces where resistive effects dominate. Key Improvements1. Inner Layer Resolution Enhancement
2. Resistive Layer Coupling
3. Field Penetration Physics
4. Singular Spot Positioning
5. Code Infrastructure
6. Numerical Robustness
Files Changed100 files modified across RDCON, RMATCH, GPEC, EQUIL, and example input files (+2613/-1894 lines) StatusWork-in-progress with ongoing refinements to resistive layer width logic and interpolation scaling. Recent commits focused on finalizing parameters for resistive metrics publication. --- | Branch: RDCON_singcoup |
|
@matt-pharr can you confirm the truncation issue is fixed and this is ready for full review? Last message from you to me ended on a cliff hanger, "Hopefully I'm not dooming it by speaking too soon!" |






Changes related to adding scientifically robust singular coupling to the RDCON -> GPEC workflow. WIP.