A new branch for snu students to incorporate local developments into …#213
Open
A new branch for snu students to incorporate local developments into …#213
Conversation
…the develop branch.
…meter and set the wanted number of solution component then this will make Solution{sol_num}.bin file containing the {sol_num}th solution on Wt. If there aren't any sol_num then this will work just as same as before.
…ializes sol_num to 1, allowing for better control of solution components.
logan-nc
reviewed
Oct 21, 2025
| @@ -0,0 +1 @@ | |||
| snu_offshoot No newline at end of file | |||
logan-nc
reviewed
Oct 21, 2025
| bin_bal2=f ! Binary output for bal_flag functions | ||
|
|
||
| netcdf_out=t ! Replicate ascii dcon.out information in a netcdf file | ||
| bernstien_flag=t |
Contributor
There was a problem hiding this comment.
Please document things as you add features and flags
logan-nc
reviewed
Oct 21, 2025
| ideal_flag=t | ||
| contour_flag=t | ||
|
|
||
| sol_num=1 |
logan-nc
reviewed
Oct 21, 2025
|
|
||
| c----------------------------------------------------------------------- | ||
| c subprogram 2. bernstein_shear. | ||
| c computes local magnetic shear S(ψ, θ) from Eq. (29) of GPEC Notes. |
Contributor
There was a problem hiding this comment.
Are these notes available to everyone? Can you add them to the repo or cite a publication?
Contributor
|
@parkjk This branch appears to have completed a clear and finite feature addition. I recommend it be cleaned up no and merged into the develop branch for everyone to enjoy. Not doing so risks sliding into a never ending state of adding features but never finishing them rigorously - which could lead to a permanent split of the SNU code from the rest of the GPEC source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the develop branch.