FOUR-25187: Processes cannot be created with BPMN files#8398
Merged
FOUR-25187: Processes cannot be created with BPMN files#8398
Conversation
caleeli
reviewed
Jul 30, 2025
Contributor
caleeli
left a comment
There was a problem hiding this comment.
Please review is the Semantic.xsd matches the official standar https://www.omg.org/spec/BPMN/20100501/Semantic.xsd
caleeli
reviewed
Jul 31, 2025
|
|
||
| // Some BPMN definitions created in others modelers doesn't comply BPMN 2.0 | ||
| // So, should be fixed | ||
| $fixBpmnSchemaService = new FixBpmnSchemaService(); |
Contributor
There was a problem hiding this comment.
Register the service and use the Laravel style to register services:
$fixBpmnSchemaService = app(FixBpmnSchemaService::class);
caleeli
requested changes
Aug 1, 2025
Contributor
caleeli
left a comment
There was a problem hiding this comment.
Please add a test to the implementation
caleeli
approved these changes
Aug 4, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
The BPMN files generated by the modeler used by the client cannot be imported into PM. However, it works perfectly with other BPMN files from different modelers.
Solution
The XSD definition used by ProcessMaker restricts some definitions found in the client’s BPMN files. A couple of these restrictions have been modified to allow the client’s files to be imported.
How to Test
Create a new process and use one of the BPMN files provided in the ticket.
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-25187
Important Note
With this change, the BPMN files provided by the client can be imported. However, our modeler does not automatically fix the visual layout of certain elements in their designs (likely due to differences in scaling and icon sizes between the two modelers).
Code Review Checklist