Swift 3 migrated #1
Conversation
fillito
left a comment
fillito
left a comment
There was a problem hiding this comment.
Thanks for this contribution!
I added a few comments
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
This file shouldn't be versioned. Could you remove the whole xcuserdata from the repository and add it to the gitignore? We should have added created a gitignore file in the first place.
You could copy this one for instance https://github.com/Produkt/Pelican/blob/master/.gitignore
|
|
||
|
|
||
| func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool { | ||
| private func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool { |
There was a problem hiding this comment.
Is there any particular reason to mark this function as private?
There was a problem hiding this comment.
I'm not quite sure 🤔. The auto-migrator marked it that way for some reason
| override func willMoveToAnimator(dynamicAnimator: UIDynamicAnimator?) { | ||
| super.willMoveToAnimator(dynamicAnimator) | ||
| override func willMove(to dynamicAnimator: UIDynamicAnimator?) { | ||
| super.willMove(to: dynamicAnimator) |
There was a problem hiding this comment.
It seems that you are using tabs over spaces. I don't have a strong opinion about this, but it would be great to keep 4 spaces for consistency in this project.
Sorry for this style nazi comment 😓
There was a problem hiding this comment.
No worries 😅 I'm used to changing my indentation style for my OSS work (I've always used the defaults for some reason, maybe I should change 🧐
2 participants
No description provided.