Open
Conversation
Member
|
Don't change the version number in the pull request |
Member
|
I would suggest this gets separated and merged to master directly. The fluxsurfaces_performance branch is just for timing and allocations and shouldn't change behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @bclyons12
Current squareness from values are very noisy (and upper/lower triangularity can be as well near axis).
I'd propose switching to use MHX for those quantities. One issue is that MHX does not differentiate between upper/lower triangularity and squareness for individual quadrants. How to handle that?