Add cq support, tracking compression ratio and average bitrate#73
Open
SuperCat908809 wants to merge 23 commits intoProryanator:mainfrom
Open
Add cq support, tracking compression ratio and average bitrate#73SuperCat908809 wants to merge 23 commits intoProryanator:mainfrom
SuperCat908809 wants to merge 23 commits intoProryanator:mainfrom
Conversation
…ing VMAF score and made engine/permutation_engine.rs use it in calc_vmaf_score.
… and displayed during permutor-cli execution and in the output log.
… and displayed during permutor-cli execution and in the output log.
Author
…/encoder-benchmark into adding-cq-support
Author
|
It seems attempting to rebase my work backfired. I'll have to live with it then. |
Owner
|
Thank you for opening this PR! I think there are a good amount of overlapping updates like the AV1 PR, so I'll hold off on reviewing this one until that other one is merged in. That would make this update a lot smaller in scope (already having merged in new changes like the enum, any package updates or other README updates, etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my second attempt at implementing the constant quality control parameter to this project. The first is here #70 though its been closed.
In order:
This is my second attempt at this pull request since I didn't realise I was using the wrong github account when I was working on this. I rebased everything with this account as the correct author.