-
Notifications
You must be signed in to change notification settings - Fork 222
Add --json-output flag documentation for CLI commands
#558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f5faabc to
d080d06
Compare
Document the new --json flag that outputs results in machine-readable JSON format: - Add --json to Universal Flags in CLI overview - Add JSON Output sections to deploy and run command docs with examples
d080d06 to
0c3f643
Compare
mohammadfawaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
AleoAlexander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, but otherwise LGTM!
Co-authored-by: Alexander Kim <alexander@aleo.org> Signed-off-by: Joshua Batty <joshpbatty@gmail.com>
|
I'm making some changes to the linked PR that change the definition. Will put this in draft until we have finalised the CLI implementation. |
- Rename --json to --json-output - Document default output location (build/json-outputs/<command>.json) - Document custom path option (--json-output=path) - Remove stdout piping examples (no longer needed)
--json flag documentation for CLI commands--json-output flag documentation for CLI commands
|
@AleoAlexander This is ready for review again now. The CLI changes have been merged in the linked PR. Thanks. |
mohammadfawaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
Documents the
--json-outputflag for saving structured CLI output to disk.Changes
build/json-outputs/<command>.json--json-output=path/to/file.jsondeploy,upgrade,run,execute,test,query,synthesizeRelated implementation: ProvableHQ/leo#29051