Pin torchao==0.12.0 to avoid PyTorch ABI warnings, also pin numpydoc>=1.6.0 and ty==0.0.1a21 for compatibility.
#417
Conversation
|
This PR has been inactive for 10 days and is now marked as stale. |
|
Not stale. |
…pruna into pin-torchao-version
|
I've pinned the sphinx version to avoid a conflict with jinja. Currently, the janus test is failing since the version supporting it is not being installed while testing. Can I add a step like Secondly, the linting with ty seems to be failing due to updates in the newer version of ty, could we pin this package as well. WDYT? |
|
Could you please review? |
davidberenstein1957
requested review from
davidberenstein1957 and
johannaSommer
davidberenstein1957
left a comment
davidberenstein1957
left a comment
There was a problem hiding this comment.
@ParagEkbote, could you rebase on main_ Also, it seems one of the tests is failing because the Janus architecture is not being recognised? Perhaps we should see if this is caused by wrong transformer versions.
pyproject.toml
Outdated
| "hqq==0.2.7.post1", | ||
| "torchao", | ||
| "torchao==0.12.0", | ||
| "Sphinx>=4.5,<7.0", |
There was a problem hiding this comment.
why are we doing this?
There was a problem hiding this comment.
We need to pin the sphinx error to prevent a version conflict with jinja. The GH Action logs for the same:https://github.com/PrunaAI/pruna/actions/runs/18781274712/job/53587851292
There was a problem hiding this comment.
Furthermore, I have also pinned the ty version and transformers version, so the test and linting checks are passing. Could you please review?
There was a problem hiding this comment.
Sphinx is only a dev dependency so we shouldn't pin it here. I don't understand why we're pinning it in the first place and the logs are not available anymore (sorry for the delay), could you re-explain / re-run the logs please?
davidberenstein1957
left a comment
davidberenstein1957
left a comment
There was a problem hiding this comment.
hi @ParagEkbote sorry for the outcome of this PR. I feel that the resctrictions w.r.t. the versioning don't outweigh the benefits of skipping the warning message in this case. WDYT @johannaSommer ?
Can we consider updating the torch version so that a newer version of torchao can be used? |
Hey @ParagEkbote @davidberenstein1957 thanks for the progress so far! Only catching up now but definitely yes, we can upgrade the torch version and then we should be able to support also newer versions of torchao. Infact @gsprochette is currently working on this torch update, maybe he can give a quick heads up as to when this will be merged. |
|
I think you only see this requirement of transformer>=4.57.3 because gliner resolved to 0.2.24 on your side, but lower versions are compatible with the requirements of pruna. Running We should not constraint the transformers version unless the code in pruna is incompatible with these anterior versions, so I'm in favor of not touching the transformers version in this PR. |
Do we need to guard against a future transformers v5 for breaking changes or not touch that as well? cc: @gsprochette |
|
I don't think it's necessary for now to guard against the future transformers versions, we'll restrict compatibility if necessary when the version comes out |
ParagEkbote
changed the title
torchao version to avoid warning of PyTorch ABI, update transformers version and pin some depstorchao==0.12.0 to avoid PyTorch ABI warnings, also pin numpydoc>=1.6.0 and ty==0.0.1a21 for compatibility.
|
I have unpinned transformers as suggested. Could you please review? cc: @gsprochette |
gsprochette
left a comment
gsprochette
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for your work :) @johannaSommer it would be cool to merge this soon to stabilize the CI
* feat/kid-metric and updated docs * fixed typo * fixed linting error * moving KID logic to enum * fixing linting error * fixed another linting error * fixing linting error
|
Hello @ParagEkbote . It turns out that #457 requires the version pinning that you do here so your PR should be merged before the uv.lock deleting one. Deleting the uv.lock here seems to create a conflict here and the tests can't run, you can just restore it here and I'll take care of that problem with the other PR :) PS: pinging @johannaSommer |
…pruna into pin-torchao-version
I have added back the uv lock file 👍 cc: @gsprochette |
5 participants
Description
As described in the issue, this PR pins the torchao version to 0.12.0. If we want to support a version higher, we will need to bump the torch version as well. After pinning to this version, the warning does not appear. Could you please review?
cc: @davidberenstein1957
Related Issue
Fixes #411
Type of Change
How Has This Been Tested?
Checklist
Additional Notes
Note
Pins
torchaoto version0.12.0to avoid the PyTorch ABI warning.Written by Cursor Bugbot for commit 474202c. This will update automatically on new commits. Configure here.