Test improvements #432
Draft
Test improvements #432
+281
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes and refactors for the Decentralized Integration Tests.
I think it'd be better to first merge #378 as it's more prioritary and then I can solve merge issues in this PR.
Main functional change is we try to print the last 150 lines of error logs if a container crashes, by monitoring it's health periodically. Before this change sometimes we'd have crashes and no logs.
Also I've tried to refactor a bit to simplify code and make it more standardized across tests by creating a
TestContextstruct that holds the docker watcher, solana client, etc. inside, and also handles the initialization which was common across tests.