Prevent panic in lender claim calculation #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an unchecked
unwrap()in the lender claim calculationthat could cause the program to panic under arithmetic edge cases.
Details
The redeemable amount calculation previously relied on
unwrap()whenconverting from
u128tou64. While the inputs are expected to be safeunder normal conditions, malformed or extreme values could trigger a
panic, resulting in a hard denial-of-service for the instruction.
This change replaces the
unwrap()with checked arithmetic and expliciterror handling, returning a program error instead of panicking