Skip to content

fix: windows server 2019 activation failing because of incomplete entry in KmsDataBase.xml #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rileran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: windows server 2019 activation failing because of incomplete entry in KmsDataBase.xml #143

Rileran wants to merge 1 commit into from

Conversation

@Rileran
Copy link

@Rileran Rileran commented Jan 22, 2026

This fixes issue #138, where Windows Server 2019 would not work because of an entry in KmsDataBase.xml.

The entry for Windows Server 2019 (Azure Only) is missing MinKeyId and MaxKeyId which are required for pykms to compute the pid.

		<CsvlkItem DisplayName="Windows Server 2019 (Azure Only)" ReleaseDate="2018-10-02T00:00:00Z" GroupId="206" IniFileName="Windows" Id="3c006fa7-3b03-45a4-93da-63ddc1bdce11">
			<Activate KmsItem="8449b1fb-f0ea-497a-99ab-66ca96e9a0f5" />
			<Activate KmsItem="cbdcb1ba-e093-4c81-a463-10775291fdf9" />
		</CsvlkItem>

What this PR does is ignoring any invalid entries in the XML file, preventing the pid_generator from not returning when other valid entries exists.

@Rileran Rileran mentioned this pull request Jan 22, 2026
Open
@Rileran Rileran force-pushed the fix/windows-server-2019 branch from 92f904b to ecf50e0 Compare January 22, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Rileran