Skip to content

Return converted times from convert_time instead of printing #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Laksh0p wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Return converted times from convert_time instead of printing #66

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa67452
Return converted times from convert_time instead of printing
Laksh0p Feb 5, 2026
4dd441e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 5, 2026
f567b83
Update return type of function in worldclock.py
Laksh0p Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pybites_tools/worldclock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
MINUTES_IN_HOUR = range(0, 60)
MONTHS_IN_YEAR = range(1, 13)
MAX_DAYS_IN_MONTH = range(1, 32)

load_dotenv()


Expand All @@ -29,14 +28,14 @@ def convert_time(
day: int = None,
tzone: str = None,
date_offset: bool = False,
) -> None:
) -> list[tuple[str, str]]:
results = []
try:
timezones = json.loads(os.environ["TIMEZONE_LIST"])
except json.decoder.JSONDecodeError:
raise WorldClockException(
"JSON error occurred. Please check your .env file for syntax"
)

for zone in timezones:
if tz.gettz(zone) is None:
raise WorldClockException(
Expand All @@ -62,8 +61,8 @@ def convert_time(

if date_offset:
formatted_time += f" {converted_time.strftime('%d %b %Y')}"

print(f"{zone:25} {formatted_time}")
results.append((zone, formatted_time))
return results


def main():
Expand All @@ -83,7 +82,7 @@ def main():

args = parser.parse_args()
try:
convert_time(
result = convert_time(
args.hour,
args.minute,
args.year,
Expand All @@ -95,6 +94,8 @@ def main():
except WorldClockException as exc:
print(exc)
sys.exit(1)
for zone, time in result:
print(f"{zone:25} {time}")


if __name__ == "__main__":
Expand Down