[wip] Add support for functions declarations with port list#101
Open
noloerino wants to merge 3 commits intoPyHDI:developfrom
Open
[wip] Add support for functions declarations with port list#101noloerino wants to merge 3 commits intoPyHDI:developfrom
noloerino wants to merge 3 commits intoPyHDI:developfrom
Conversation
Author
|
I did some more testing, and it seems like there's still some edge cases to fix. I'll let you know when this is ready for review. |
noloerino
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #100.
This code may allow illegal
outputdefinitions as well (such asfunction [3:0] f(output a); endfunction), though this case seems somewhat pathological. Fixing it would require adding a few more parser rules, which I can do if requested.Please let me know if any other changes should be made.