Migrate setup.py to pyproject.toml and add pixi configuration#854
Open
tfehlmann wants to merge 2 commits intoPyLabRobot:mainfrom
Open
Migrate setup.py to pyproject.toml and add pixi configuration#854tfehlmann wants to merge 2 commits intoPyLabRobot:mainfrom
tfehlmann wants to merge 2 commits intoPyLabRobot:mainfrom
Conversation
…ixi configuration Replace the imperative setup.py with declarative PEP 621 metadata in pyproject.toml. All dependencies, optional extras, entry points, and package data are preserved identically — verified via wheel content diff against the previous setup.py build. Add pixi configuration for automatic binary dependency management (libusb, libftdi, libhidapi) via conda-forge, with tasks mirroring the Makefile (test, lint, format, typecheck). Users who do not use pixi are unaffected; pip install continues to work as before.
pixi.lock
Outdated
Contributor
Author
There was a problem hiding this comment.
can be dropped, although since you pinned all packages that's just a more precise pinning, but will drop it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.pyto declarative PEP 621 metadata inpyproject.tomlsetup.pyDetails
pyproject.toml migration
All
setup()arguments are converted to their PEP 621 equivalents:setuptools>=68.0withsetuptools.build_metabackendpylabrobot/version.txtvia[tool.setuptools.dynamic]install_requiresandextras_requiregroups preserved with identical pinslh-serverandplr-guiconsole scriptsnamespaces = falseto matchfind_packages()behavior exactlyvisualizer/*andversion.txtunchangedExisting
[tool.ruff]configuration is preserved.Pixi configuration
Adds
[tool.pixi.*]sections for automatic binary dependency management:fwlibusbplate-readinglibftdiinhecolibhidapidevEach feature environment includes editable PyPI installation with the corresponding extras.
Pixi tasks mirror the Makefile:
test,lint,format,format-check,typecheck.Users who do not use pixi are completely unaffected —
pip installworks identically.Verification
pip install -e '.[dev]'succeedspython -m buildproduces valid wheel and sdistsetup.pybuild (verified via diff)python -c "from pylabrobot import __version__"returns0.1.6lh-server,plr-gui) resolve correctlypython -m pytestandpixi run -e dev testTest plan
pip install -e '.[dev]'workspython -m buildproduces valid artifacts