[WIP] Change RNG seed generation scheme.#1174
Open
ye-luo wants to merge 1 commit intoQMCPACK:developfrom
Open
Conversation
Contributor
|
Contributor
|
See #1176 |
Contributor
|
What is the typical resolution of "high_resolution_clock" in std::chrono? Would really like the probability of repeated clock based seeds to be near zero (e.g. no repeats as in #1068, but guaranteed for an even larger set of runs). |
Contributor
|
why not use a hardware random source? I think openssl offers easy access to hardware random bytes on any platform we use? Take the seed from there, you can still record it but you shouldn't have to worry about collisions. |
Contributor
|
I have some better ideas on how to handle this now. A good topic for v4 but we need the batched code first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step 1, get initial seed by time std::chrono
step 2, generate seeds for RNGs used by MC. Each rank needs omp_get_max_threads()+1 seeds. jump ahead rank()*(omp_get_max_threads()+1) with discard(). Very fast 0.14 sec for 10^8.
step 3, seed the per-rank RNG.
step 4, seed the per-thread RNG.
After dive in the code a bit, I feel a lot of cleaning is needed.
Mostly RandomGenerator_t needs to be simplified. All the information about MPI and threads should be removed.