Skip to content

Reinstall #5382 (deterministic-diamondC_1x1x1_pp-multi_dmc_sdj-1-1-2-mpc related fixes)#5424

Merged
ye-luo merged 3 commits intoQMCPACK:developfrom
prckent:mpctol
Apr 7, 2025
Merged

Reinstall #5382 (deterministic-diamondC_1x1x1_pp-multi_dmc_sdj-1-1-2-mpc related fixes)#5424
ye-luo merged 3 commits intoQMCPACK:developfrom
prckent:mpctol

Conversation

@prckent
Copy link
Contributor

@prckent prckent commented Apr 6, 2025

Proposed changes

Address occasional statistical failures, e.g. https://cdash.qmcpack.org/testSummary.php?project=1&name=deterministic-diamondC_1x1x1_pp-multi_dmc_sdj-1-1-2-mpc&date=2025-04-04

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Apr 6, 2025

#5389 reverted my fix #5382 to #5377. all the tests were fine before the Thursday regression. Need to address the regression.

@prckent prckent changed the title Increase tolerance for deterministic-diamondC_1x1x1_pp-multi_dmc_sdj-1-1-2-mpc Reinstall #5382 (deterministic-diamondC_1x1x1_pp-multi_dmc_sdj-1-1-2-mpc related fixes) Apr 7, 2025
@ye-luo ye-luo enabled auto-merge April 7, 2025 14:13
@ye-luo
Copy link
Contributor

ye-luo commented Apr 7, 2025

Test this please

@ye-luo ye-luo merged commit 59fe4be into QMCPACK:develop Apr 7, 2025
41 checks passed
@prckent prckent deleted the mpctol branch January 14, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants