Remove pandas dependency from QMCPACK tests#5732
Conversation
…or/CMakeLists.txt`, and `ornl_setup_environments.sh`
|
I would like to review this ahead of merge. |
|
Always good to reduce dependencies. Quick Q: What errors do you get with PyscfToQmcpack_Spline.py? How are you invoking it, what are you using it with (etc.)? We do have a test on it and it is meant to work. Again, like the other dependencies the pandas use should be minimal. |
|
I've not actually directly called up I can't start to remove the |
|
On the splines, ** noting that it is not critical for this PR **: https://cdash.qmcpack.org/tests/42285105 shows it is "working" when PySCF is installed. However, the processing of the output fails in subsequent tests. There are some problems that need investigating. Could be test environment and not the tests. |
There was a problem hiding this comment.
Please remove changes from ornl_setup_environments.sh. More comments may follow.
(In general, please don't touch any test setup related config files without checking. We still actually need pandas! Removing it would break the spline conversion and potentially other uses.)
|
Assuming it works first try, I would like to see the results of #5735 before merging this. If not, this does look OK to merge and we should not hold it up further. #5735 will add some tests to the CI that are not currently run and that go through the pandas usage. I expect that this PR will pass with no further updates. [ This situation is another good motivation for getting python coverage working and reported on codecov. ] |
prckent
left a comment
There was a problem hiding this comment.
Approving to unblock and allow merge if CI looks OK.
Tested by hand but did not try to trigger failure conditions
|
Test this please |
Proposed changes
This PR removes the dependency on the Python package
pandasin QMCPACK tests which reduces the requirements for running testing. The affected tests areestimator/sofkandestimator/latdev.In theory there is still a pandas dependency in
src/QMCTools/PyscfToQmcpack_Spline.py, however that file has other errors that prevent me from testing it (in lines 133, 141, and 146). Since this can't be run, I don't think it matters much ifpandasis removed from the QMCPACK docker files, although that is a job for @prckent if he thinks it's the right move.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop
Checklist