SPOSet size required at construction#5842
Merged
prckent merged 4 commits intoQMCPACK:developfrom Mar 6, 2026
Merged
Conversation
Contributor
Author
|
Test this please |
prckent
reviewed
Mar 6, 2026
| static auto countOrbitals(const std::vector<std::unique_ptr<SPOSetT<T>>>& components) | ||
| { | ||
| SPOSet::OrbitalSetSize = 0; | ||
| component_offsets.reserve(4); |
Contributor
There was a problem hiding this comment.
Small q: Why did we reserve 4 here previously?
Contributor
Author
There was a problem hiding this comment.
When having two spos. Offset needs to be size 3 at least. Not sure why 4.
prckent
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is a long overdue change. With this PR
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist