Skip to content

Remove SPO index shifting feature in BsplineSet#5843

Merged
prckent merged 4 commits intoQMCPACK:developfrom
ye-luo:refactor-splines
Mar 7, 2026
Merged

Remove SPO index shifting feature in BsplineSet#5843
prckent merged 4 commits intoQMCPACK:developfrom
ye-luo:refactor-splines

Conversation

@ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Mar 7, 2026

Proposed changes

  1. This feature was never activated nor tested. calls to selectBands always set relative=false.
  2. It should not be implemented in the current way even if this feature is needed. Thus remove first_spo and last_spo.
  3. Remove unused selectBands variants.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor Author

ye-luo commented Mar 7, 2026

Test this please

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the rationale.

Also, this is a feature that would be better handled by outside processing should anyone ever need something similar.

@prckent prckent merged commit 85217b9 into QMCPACK:develop Mar 7, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants