Refactor detecting end token in parsing lists of items #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces some clumsy code, with more efficient and cleaner code. Various types, "flavors" of lists are parsed with a single function. Each kind of list has a token or token that signifys no more items when encountered. This commit factors this into a single function and removes some redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces some clumsy code with more efficient and cleaner code.
Various types-- "flavors" --of lists are parsed with a single function. The flavor is sent as a parameter to this function so that particulars may be treated correctly. Furthermore, each kind of list has a token or token that signifies no more items when it is encountered. This commit factors this check for end tokens into a single function and removes some redundancy.