Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pallets/reversible-transfers/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -552,10 +552,10 @@ pub mod pallet {
fn validate_delay(delay: &BlockNumberOrTimestampOf<T>) -> DispatchResult {
match delay {
BlockNumberOrTimestamp::BlockNumber(x) => {
ensure!(*x > T::MinDelayPeriodBlocks::get(), Error::<T>::DelayTooShort)
ensure!(*x >= T::MinDelayPeriodBlocks::get(), Error::<T>::DelayTooShort)
},
BlockNumberOrTimestamp::Timestamp(t) => {
ensure!(*t > T::MinDelayPeriodMoment::get(), Error::<T>::DelayTooShort)
ensure!(*t >= T::MinDelayPeriodMoment::get(), Error::<T>::DelayTooShort)
},
}
Ok(())
Expand Down Expand Up @@ -788,7 +788,7 @@ pub mod pallet {
};
// For assets, burn held funds (fee) and transfer remaining to interceptor
// For native balances, burn held funds (fee) and transfer remaining to interceptor
if let Ok((call, _)) = T::Preimages::peek::<RuntimeCallOf<T>>(&pending.call) {
if let Ok((call, _)) = T::Preimages::realize::<RuntimeCallOf<T>>(&pending.call) {
if let Ok(pallet_assets::Call::transfer_keep_alive { id, .. }) =
call.clone().try_into()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1992,3 +1992,33 @@ fn cancelled_reversible_transfer_does_not_record_proof() {
);
});
}

#[test]
fn validate_delay_accepts_delay_equal_to_minimum() {
new_test_ext().execute_with(|| {
let user = charlie();
let interceptor = dave();
let delay = BlockNumberOrTimestamp::BlockNumber(MinDelayPeriodBlocks::get());

assert_ok!(ReversibleTransfers::set_high_security(
RuntimeOrigin::signed(user),
delay,
interceptor,
));
});
}

#[test]
fn validate_delay_accepts_timestamp_equal_to_minimum() {
new_test_ext().execute_with(|| {
let user = charlie();
let interceptor = dave();
let delay = BlockNumberOrTimestamp::Timestamp(MinDelayPeriodMoment::get());

assert_ok!(ReversibleTransfers::set_high_security(
RuntimeOrigin::signed(user),
delay,
interceptor,
));
});
}