feat: Test/fees structure and user volume#519
Open
Anuoluwapo25 wants to merge 1 commit intoQuickLendX:mainfrom
Open
feat: Test/fees structure and user volume#519Anuoluwapo25 wants to merge 1 commit intoQuickLendX:mainfrom
Anuoluwapo25 wants to merge 1 commit intoQuickLendX:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
📝 Description
This PR adds comprehensive unit tests for the fee structure and user transaction volume logic in the Soroban smart contract.
🎯 Type of Change
🔧 Changes Made
Files Modified
New Files Added
Files Modified
Added tests for get_fee_structure across all FeeType variants
Added tests validating fee structure updates
Added tests for get_user_volume_data with zero initial state
Added tests for update_user_transaction_volume behavior
Added tests validating volume tier boundaries
Ensured coverage across edge cases and boundary conditions
New Files Added
Key Changes
🧪 Testing
Test Coverage
Fee Structure
Retrieve fee structure for each FeeType
Verify values after updating fee configuration
Validate correct storage and retrieval behavior
User Volume Data
Initial state returns zero transaction volume
After update_user_transaction_volume, volume updates correctly
Retrieval via get_user_volume_data returns expected values
Volume Tier Boundaries
Tests at exact boundary values
Tests just below tier thresholds
Tests just above tier thresholds
📋 Contract-Specific Checks
Contract Testing Details
📋 Review Checklist
🔍 Code Quality
🚀 Performance & Security
📚 Documentation
🔗 Related Issues
Closes #347
Fixes #347
📋 Additional Notes
🧪 How to Test
📸 Screenshots (if applicable)
🔄 Migration Steps (if applicable)
📋 Reviewer Checklist
Code Review
Contract Review
Documentation Review
Testing Review