Performance issue in permanent user list page#72
Open
h-nargesi wants to merge 7 commits intoRADIUSdesk:cake4from
Open
Performance issue in permanent user list page#72h-nargesi wants to merge 7 commits intoRADIUSdesk:cake4from
h-nargesi wants to merge 7 commits intoRADIUSdesk:cake4from
Conversation
instead of query for each user, it is efficient to make query at once for all of them.
Update cake4
Update from RADIUSdesk/rdcore
Update `hotfix/permanent-user-list-performance` 10-31-2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of execute queries in a loop (that has sires performance issue), we can run a query for all of the users and store result in a dictionary and then use it in that loop.
Also add
acctstarttimecolumn inusernameindex onradaccttable will help to run this query in a better state.