Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
ebeacf5
some work on camera
AdornedJoker Dec 26, 2025
888a4a3
headers
AdornedJoker Dec 26, 2025
b030d0f
moved some functions to header
AdornedJoker Dec 26, 2025
4c121ae
alright
AdornedJoker Dec 26, 2025
79b58f0
Update Camera.h
AdornedJoker Dec 26, 2025
110862f
first time with doing reflections
AdornedJoker Dec 26, 2025
5e27d86
the removal of descriptors in the header
AdornedJoker Dec 27, 2025
ea2c7ba
changed assertion to be less lazy
AdornedJoker Dec 27, 2025
5fd20b6
styling!
AdornedJoker Dec 27, 2025
77eb8ab
moved vars into if block
AdornedJoker Dec 27, 2025
e88d131
lowercased and made code less ugly
AdornedJoker Dec 27, 2025
2e8e8e7
removed something unnecessary
AdornedJoker Dec 27, 2025
97ff24c
Camera::Camera()
AdornedJoker Dec 28, 2025
8f80071
Camera::setCameraSubject
AdornedJoker Dec 28, 2025
2796b65
more styling
AdornedJoker Dec 28, 2025
85920f2
forgot some
AdornedJoker Dec 28, 2025
98faa13
merge conflict fix attempt
AdornedJoker Dec 29, 2025
3e737bc
Merge branch 'master' into somethingCamera
AdornedJoker Dec 29, 2025
7ca1697
Merge branch 'RBLXDecomp:master' into somethingCamera
AdornedJoker Jan 4, 2026
24b0926
More Functions!
AdornedJoker Jan 4, 2026
221811d
agonizing work
AdornedJoker Jan 4, 2026
9992a67
i gave up
AdornedJoker Jan 4, 2026
1946f67
Merge branch 'master' into somethingCamera
AdornedJoker Jan 17, 2026
32832ca
Update App.vcproj
AdornedJoker Jan 17, 2026
efd9a61
ok
AdornedJoker Jan 20, 2026
d4edbd8
zoomExtents
AdornedJoker Jan 20, 2026
d005f1f
updateGoal matching to 87.80%
AdornedJoker Jan 21, 2026
36e00d3
tryZoomExtents and headers
AdornedJoker Jan 21, 2026
3aca5c5
simplification
AdornedJoker Jan 21, 2026
06a2a36
setDistanceFromTarget
AdornedJoker Jan 21, 2026
984bf9b
Merge branch 'master' into somethingCamera
AdornedJoker Feb 23, 2026
374c111
Update App.vcproj
AdornedJoker Feb 23, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Client/App/App.vcproj
Original file line number Diff line number Diff line change
Expand Up @@ -804,11 +804,11 @@
<File
RelativePath=".\include\v8datamodel\FaceInstance.h"
>
</File>
<File
</File>
<File
RelativePath=".\include\v8datamodel\Feature.h"
>
</File>
</File>
<File
RelativePath=".\include\v8datamodel\GlobalSettings.h"
>
Expand Down Expand Up @@ -1286,6 +1286,10 @@
RelativePath=".\v8datamodel\BrickColor.cpp"
>
</File>
<File
RelativePath=".\v8datamodel\Camera.cpp"
>
</File>
<File
RelativePath=".\v8datamodel\Decal.cpp"
>
Expand Down
6 changes: 5 additions & 1 deletion Client/App/include/util/Extents.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ namespace RBX
NormalId closestFace(const G3D::Vector3& point);
void unionWith(const Extents& other);
void shift(const G3D::Vector3&);
void scale(float);
void scale(float scale)
{
this->low *= scale;
this->high *= scale;
}
void expand(float f)
{
this->low -= G3D::Vector3(f, f, f);
Expand Down
35 changes: 19 additions & 16 deletions Client/App/include/v8datamodel/Camera.h
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#pragma once
#include "v8tree/Instance.h"
#include <G3D/GCamera.h>
#include <G3D/CoordinateFrame.h>
#include <G3D/Rect2D.h>
#include <G3D/Array.h>
#include "v8tree/Instance.h"
#include "util/Extents.h"

namespace RBX
Expand Down Expand Up @@ -54,17 +54,17 @@ namespace RBX
void updateFocus();
void updateGoal();
bool characterZoom(float);
bool nonCharacterZoom(float);
void tryZoomExtents(float, float, float, const Extents&, const G3D::Rect2D&);
bool nonCharacterZoom(float in);
void tryZoomExtents(float low, float current, float high, const RBX::Extents& extents, const G3D::Rect2D& viewPort);
ContactManager& getContactManager();
float goalToFocusDistance() const;
void setGCameraCoordinateFrame(const G3D::CoordinateFrame&);
G3D::CoordinateFrame computeLineOfSiteGoal();
void getHeadingElevationDistance(float&, float&, float&);
void getHeadingElevationDistance(float& heading, float& elevation, float& distance);
void setHeadingElevationDistance(float, float, float);
void tellCameraMoved();
void getIgnorePrims(G3D::Array<const Primitive*>&);
virtual bool askSetParent(const Instance*) const;
virtual bool askSetParent(const Instance* instance) const;
public:
//Camera(const Camera&);
Camera();
Expand All @@ -81,29 +81,32 @@ namespace RBX
bool isFirstPersonCamera() const;
ICameraSubject* getCameraSubject() const;
Instance* getCameraSubjectInstance() const;
void setCameraSubject(Instance*);
const G3D::CoordinateFrame& getCameraFocus() const;
void setCameraFocus(const G3D::CoordinateFrame&);
void setCameraSubject(Instance* newSubject);
const G3D::CoordinateFrame& getCameraFocus() const
{
return cameraFocus;
}
void setCameraFocus(const G3D::CoordinateFrame& value);
G3D::CoordinateFrame getCameraCoordinateFrame() const
{
return gCamera.getCoordinateFrame();
}
void setCameraCoordinateFrameNoLerp(const G3D::CoordinateFrame&);
void setCameraCoordinateFrameNoLerp(const G3D::CoordinateFrame& value);
void goalToCamera();
CameraType getCameraType() const;
void setCameraType(CameraType);
void setCameraType(CameraType type);
bool canZoom(int) const;
bool canTilt(int) const;
void onWrapMouse(const G3D::Vector2&);
bool zoom(float);
bool setDistanceFromTarget(float);
void zoomExtents(Extents, const G3D::Rect2D&, ZoomType);
bool zoomExtents(const G3D::Rect2D&);
void panRadians(float);
bool zoom(float in);
bool setDistanceFromTarget(float newDistance);
void zoomExtents(Extents extents, const G3D::Rect2D& viewPort, ZoomType zoomType);
bool zoomExtents(const G3D::Rect2D& viewPort);
void panRadians(float angle);
void panUnits(int);
bool tiltRadians(float);
bool tiltUnits(int);
void lookAt(const G3D::Vector3&);
void lookAt(const G3D::Vector3& point);
void setImageServerViewNoLerp(const G3D::CoordinateFrame&, const G3D::Rect2D&);
public:
//Camera& operator=(const Camera&);
Expand Down
Loading