Conversation
staverm
force-pushed
the
staverm/a2a_tests
branch
2 times, most recently
from
2ecbbd5 to
1916594
Compare
staverm
force-pushed
the
staverm/a2a_tests
branch
from
1916594 to
161c286
Compare
staverm
force-pushed
the
staverm/a2a_tests
branch
from
161c286 to
acb976b
Compare
| errors.append( | ||
| "Field 'skills' must be an array of AgentSkill objects." | ||
| ) | ||
| elif not card_data['skills']: |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Validation code was taken from a2a-inspector which was developed by google so I assumed it's correct. The A2A SDK doesn't enforce non-empty skills list, but the type annotation is list[AgentSkill] and not list[AgentSkill] | None = None (which they do for some other fields). So I think their intention was for there to always be at least one skill. Still I wouldn't mind relaxing this.
Member
There was a problem hiding this comment.
Probably makes sense to stick with the check then--just remember to verify debater example when you rebase 😄
peterjgilbert
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.