Skip to content

compiler: unblock egress#10

Merged
nhynes merged 1 commit intomainfrom
nhynes/unblock-egress
Feb 4, 2026
Merged

compiler: unblock egress#10
nhynes merged 1 commit intomainfrom
nhynes/unblock-egress

Conversation

@nhynes
Copy link
Member

@nhynes nhynes commented Feb 4, 2026

This fixes an issue with the docker-compose reporter (and possibly the k8s reporter) where internet egress was mistakenly disallowed

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c881c4c899

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +886 to +890
// Allow DNS (cluster resolvers are usually local).
netpol.add_egress_rule(NetworkPolicyEgressRule {
to: vec![NetworkPolicyPeer {
pod_selector: None,
namespace_selector: None,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard default egress rules to avoid blocking private services

NetworkPolicy::new defaults to policy_types: ["Ingress"], so previously components with no egress_from_consumers or egress_to_router ended up with no egress rules and therefore retained unrestricted egress. With this change, every component always gets DNS + “internet” egress rules and an ipBlock that excludes LOCAL_NETWORK_CIDRS, which implicitly enables Egress policy for all pods and blocks private/VPC/cluster ranges even when the component has no explicit egress bindings. That is a behavior change from the previous gating and will break workloads that rely on reaching private endpoints (e.g., databases or cluster services not represented in Amber bindings). Consider re‑introducing the conditional so these rules are only added when egress restrictions are intended.

Useful? React with 👍 / 👎.

@nhynes nhynes force-pushed the nhynes/unblock-egress branch from c881c4c to 23b22f6 Compare February 4, 2026 10:46
@nhynes nhynes merged commit 8e90980 into main Feb 4, 2026
13 checks passed
@nhynes nhynes deleted the nhynes/unblock-egress branch February 4, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant