Usernavigation - Check if table of contents#25
Open
kmaster2520 wants to merge 6 commits intomasterfrom
Open
Conversation
…added processing for non-html eulas, and error handled for html only eulas.
pwerner3
suggested changes
Feb 20, 2018
Contributor
pwerner3
left a comment
pwerner3
left a comment
There was a problem hiding this comment.
I think we need more than just checking if the words "Table of Contents" appears in the first 1000 characters. For example, we may also want to look for hyperlinks if we have a web link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.