implementing direct presentation to user - check if link is on homepage#33
Open
davidjtran wants to merge 1 commit intomasterfrom
Open
implementing direct presentation to user - check if link is on homepage#33davidjtran wants to merge 1 commit intomasterfrom
davidjtran wants to merge 1 commit intomasterfrom
Conversation
claytonmark
reviewed
Apr 18, 2018
| chrome_options.set_headless() | ||
|
|
||
| # Start chrome driver, and set window to initial width and height | ||
| driver = webdriver.Chrome(chrome_options=chrome_options) |
Contributor
There was a problem hiding this comment.
We should think about using Scrapy instead of chrome unless we need to render the page. Chrome headless has a huge memory overhead and high cpu load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding links on the home page. It is very easy to add other base cases so let me know if you think of anymore. Also I used "terms" to match the phrase instead of "terms of service" since some websites use only "terms".