Skip to content

Comments

fix: new ui fixes-report & repository tables#91

Merged
batzionb merged 18 commits intoRHEcosystemAppEng:new-uifrom
rhartuv:reports-table
Jan 12, 2026
Merged

fix: new ui fixes-report & repository tables#91
batzionb merged 18 commits intoRHEcosystemAppEng:new-uifrom
rhartuv:reports-table

Conversation

@rhartuv
Copy link
Contributor

@rhartuv rhartuv commented Dec 30, 2025

Handle a few bug fixes and upgrades: https://issues.redhat.com/browse/ECOPROJECT-3559

@rhartuv rhartuv changed the title Reports table New UI fixes- report & repository tables Dec 30, 2025
@rhartuv rhartuv requested a review from batzionb January 1, 2026 11:32
@rhartuv rhartuv requested a review from batzionb January 6, 2026 14:09
@rhartuv rhartuv changed the title New UI fixes- report & repository tables fix: new ui fixes-report & repository tables Jan 7, 2026
@batzionb batzionb merged commit e97890d into RHEcosystemAppEng:new-ui Jan 12, 2026
if ("state".equals(sf.field())) {
sorts.add(Sorts.descending("input.scan.completed_at"));
sorts.add(Sorts.ascending("error.type"));
} else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting for "state" exists because state is computed from multiple fields (not stored) so MongoDB can't sort by it directly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's not possible we should not enable it

Copy link
Contributor Author

@rhartuv rhartuv Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no state field, it is calculated when reading from the fields:
error.type → "expired"/ "failed"
input.scan.completed_at → "completed"
metadata.sent_at → "sent"
metadata.submitted_at → "queued"
metadata.product_id → "pending"
Therefore, sorting by "state" requires mapping to these fields.
I added this because it appears in both the old UI and FIGMA.

@rhartuv rhartuv deleted the reports-table branch January 12, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants