feat: make SBOM metadata labels keys configurable#96
Merged
vbelouso merged 1 commit intoRHEcosystemAppEng:mainfrom Jan 8, 2026
Merged
feat: make SBOM metadata labels keys configurable#96vbelouso merged 1 commit intoRHEcosystemAppEng:mainfrom
vbelouso merged 1 commit intoRHEcosystemAppEng:mainfrom
Conversation
zvigrinberg
requested changes
Jan 7, 2026
Collaborator
zvigrinberg
left a comment
zvigrinberg
left a comment
There was a problem hiding this comment.
Hi @vbelouso
This is very good, and exactly what i meant.
The maximum size of the list could be decided later, it's OK by now to have it in the range of [1,10].
Please see my comments below.
src/main/java/com/redhat/ecosystemappeng/morpheus/service/ReportService.java
Show resolved
Hide resolved
src/main/java/com/redhat/ecosystemappeng/morpheus/service/ReportService.java
Show resolved
Hide resolved
Signed-off-by: Vladimir Belousov <vbelouso@redhat.com>
Collaborator
Author
|
Thanks @zvigrinberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
AppConfigwith configurable lists for source location and commit ID property keys. This allows users to customize which SBOM properties are used to extract image source information, supporting different labeling conventions across organizations (OCI, Syft, OpenShift, custom).