Open
Conversation
Author
|
Can we... figure out a way to describe a maximum common part of the code-style of this entire repository and apply it using clang-format? This will make reading and refactoring this thing easier in the long run. What I have so far is: ---
BasedOnStyle: WebKit
# This is usually bigger
ColumnLimit: '120'
IndentPPDirectives: BeforeHash
IndentWidth: '4'
TabWidth: '4'
UseTab: ForIndentation
SpaceAfterCStyleCast: true
# DerivePointerAlignment: true
PointerAlignmentStyle: Left
# This is not uniformly done
SpacesInParentheses: true
...Note that |
Owner
|
I can't say I'm very motivated to spend any significant amount of time on that. Not that I don't see the point but I wasn't even planning on doing more than corrective maintenance on the tool as it currently is, so making the code more readable or refactoring it aren't on my agenda. Of course you can reformat as much as you want, and I'll see whether or not I have any issues with the result when you're done. Sorry...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Using thisthat" is under installation, so I moved these to level-2 titles. This should make it read more logical.
I don't really know how to rephrase the top so the biggest title is just one line.