refactor: separate results handling from core simulation logic#29
Closed
refactor: separate results handling from core simulation logic#29
Conversation
- Replace Conda/pip/setup.py with uv commands - Remove outdated requirements.txt and Nuitka build sections - Remove debugging targets (act, a, t, list, dc) - Add self-documenting help target - Add clean targets for build artifacts - Reduce from 172 to 78 lines
- Create opgee/results.py with FieldResult, lightweight Aggregator, parse_aggregators(), and get_field_result() - Transform XML: move Process elements to Field level, use ProcessRef in Aggregators for results grouping - Update Container/Field to remove old Aggregator support (aggs, descendant_aggs, find_agg) - Remove old Aggregator class from process.py and simplify xml_utils.py - Delete unused tests/files/test_gui.xml - All 274 tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opgee/results.pymodule withFieldResult, lightweightAggregator,parse_aggregators(), andget_field_result()functionsThis decouples results collection from the process hierarchy, making Aggregators purely a results-grouping concept parsed from XML rather than part of the Container/Process object model.
Test plan
uv run opg run <model.xml>