fix(types): update Markdown.test.tsx to use getAttribute#522
Merged
Conversation
Markdown.test.tsx to use getAttributeMarkdown.test.tsx to use getAttribute
Expected version change and release notes:1.5.0-dev.19 (v1.5.0-dev.18...fix-ts_errors_markdown_test ) (2025-11-05T14:39 UTC)Fixes
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes test assertions in the Markdown component tests by consistently using getAttribute() instead of direct DOM property access.
- Refactored all DOM property assertions (e.g.,
a.target,a.rel,a.href) to usegetAttribute()method - Added nullish coalescing (
?? "") for assertions expecting empty strings when attributes are absent - Changed assertions to use regex matching where appropriate (e.g.,
toMatch(/#section$/))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-522.westus2.2.azurestaticapps.net |
AlexAxthelm
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.target,.rel, etc.) withgetAttribute()nullishcoalescing for unset attributes that returnnullhreftest to usetoMatchfor more flexible assertionRelates to #514