fix: remove references to old schema fields#532
Merged
Conversation
Expected version change and release notes:1.5.0-dev.23 (v1.5.0-dev.22...511-fix_publisher_and_published_fields ) (2025-11-06T13:53 UTC)Fixes
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the pathway publication data model from a flat structure to a nested structure, aligning the code with the existing type definitions that use a Publication object with structured Label types for the publisher field.
- Updated references from
pathway.publishertopathway.publication.publisher.full - Updated references from
pathway.publicationYeartopathway.publication.year
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/searchUtils.ts | Updated search fields to access publisher and year through nested publication object |
| src/pages/PathwayDetailPage.tsx | Updated UI display to access publisher and year through nested publication object |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexAxthelm
previously approved these changes
Nov 6, 2025
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-532.westus2.2.azurestaticapps.net |
AlexAxthelm
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles the immediate bug of "Publisher:" and "Published:" values being empty on the Scenario Details page.
The broader challenge of enabling type-checking and dealing with the root of this problem more holistically by handling all
typecheckfailures is being handled concurrently (see #514 and related PRs).Closes #511