Update SGLang PD Disagg with sgl router and updated benchmarking#128
Open
gargrahul wants to merge 1 commit intoROCm:developfrom
Open
Update SGLang PD Disagg with sgl router and updated benchmarking#128gargrahul wants to merge 1 commit intoROCm:developfrom
gargrahul wants to merge 1 commit intoROCm:developfrom
Conversation
gargrahul
requested review from
Rohan138,
amathews-amd,
coketaste and
ppalaniappan-amd
as code owners
raviguptaamd
reviewed
Feb 6, 2026
| @@ -1,69 +1,57 @@ | |||
| #!/bin/bash | |||
|
|
|||
Contributor
There was a problem hiding this comment.
@lcskrishna - Any specific need for 2 benchmarking scripts ?
One says _GSP and other normal
raviguptaamd
reviewed
Feb 6, 2026
| if [ "$p_con" -lt 16 ]; then | ||
| p_con=16 | ||
| fi | ||
| echo "[RUNNING] prompts $prompts isl $isl osl $osl con $con model ${MODEL_NAME} xP=${xP} yD=${yD} job=${SLURM_JOB_ID}" | tee -a "${LOG}_CONCURRENCY.log" |
Contributor
There was a problem hiding this comment.
@lcskrishna - I believe these tags were added for benchmark results parsing. Any particular need to remove them ?
raviguptaamd
reviewed
Feb 6, 2026
| echo "${PREFILL_ARGS} are Proxy's Prefill" | ||
| echo "${DECODE_ARGS} are Proxy's Decode" | ||
| echo "================================================" | ||
| echo "Proxy server is waiting for prefile and decode nodes to be ready ..." \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.