workflow enhancement #87
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enhances the Enroot test workflow to improve automation and test coverage. Previously, tests could only be triggered manually with individual test selection. This update enables automatic testing on every commit to main while maintaining flexible on-demand execution options with test-type-specific configuration.
Technical Details
Key Changes to
.github/workflows/enroot-tests.yml:Dual Trigger Support: Added
pushtrigger for automatic execution on main branch commits alongside existingworkflow_dispatchfor manual runsNew RCCL Test Option: Added
test_multi_node_rcclas an on-demand test that runs pytest directly with hardcoded--no-install --no-uninstallflags for specialized RCCL validationMatrix Strategy with Sequential Execution: Configured
max-parallel: 1to run tests sequentially, ensuring proper resource managementConditional Execution Logic: Per-commit runs execute both single-node and multi-node PyTorch tests automatically, while RCCL test remains on-demand only
Test Plan
Test Result
✅ Workflow syntax validated successfully
✅ All conditional expressions properly structured
✅ Test-type-specific secret mapping implemented correctly
✅ RCCL test isolation verified (on-demand only)
Submission Checklist