Skip to content

Conversation

@kiran-thumma
Copy link
Contributor

Motivation

This PR enhances the Enroot test workflow to improve automation and test coverage. Previously, tests could only be triggered manually with individual test selection. This update enables automatic testing on every commit to main while maintaining flexible on-demand execution options with test-type-specific configuration.

Technical Details

Key Changes to .github/workflows/enroot-tests.yml:

  1. Dual Trigger Support: Added push trigger for automatic execution on main branch commits alongside existing workflow_dispatch for manual runs

  2. New RCCL Test Option: Added test_multi_node_rccl as an on-demand test that runs pytest directly with hardcoded --no-install --no-uninstall flags for specialized RCCL validation

  3. Matrix Strategy with Sequential Execution: Configured max-parallel: 1 to run tests sequentially, ensuring proper resource management

  4. Conditional Execution Logic: Per-commit runs execute both single-node and multi-node PyTorch tests automatically, while RCCL test remains on-demand only

Test Plan

  • Validated conditional logic for all execution paths:
    • Per-commit: Both original tests run automatically with type-specific testbed secrets
    • On-demand: All three tests selectable with optional testbed override
  • Confirmed matrix strategy properly excludes RCCL test from automatic runs
  • Tested artifact naming maintains uniqueness for parallel test results

Test Result

✅ Workflow syntax validated successfully
✅ All conditional expressions properly structured
✅ Test-type-specific secret mapping implemented correctly
✅ RCCL test isolation verified (on-demand only)

Submission Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants